Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PKG SUPPORT] changes for support of flake >=6.0.0 (and Python 3.12, implicit) #644

Open
valeriupredoi opened this issue Nov 23, 2023 · 3 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@valeriupredoi
Copy link

Hi @carlio et al (the good Prospector folk), here's your (annoying) friendly pkg maintainer - in order for Prospector to be built with Python 3.12, there are three direct dependencies that need to change lower and upper pin bounds (well, upper bound is not 100% needed, but safe):

- mccabe >=0.7.0,<0.8.0
- pycodestyle >=2.11.0,<2.12.0
- pyflakes >=3.1.0,<3.2.0

these are unfortunately dictated by flake8 >=6. Are these possible at the moment? If so, I can fire up a rebuild, and (AFAIK) even with a pylint=2.17.7 we can get us a python 3.12 supported build, so the issue of supporting pylint >=3 is not that pressing, Python 3.12-wise. Cheers muchly! 🍺

@Pierre-Sassoulas
Copy link
Collaborator

Hey, thank you for the investigation :) Feel free to open a merge request as most of the work is done. pylint 2.17.7 works with python 3.12 as long as you don't use 3.12 specific structure, but we do need pylint > 3 in the general case.

@Pierre-Sassoulas Pierre-Sassoulas added the dependencies Pull requests that update a dependency file label Nov 23, 2023
@valeriupredoi
Copy link
Author

valeriupredoi commented Nov 24, 2023

cheers muchly, mate! Will open a PR on the feedstock and one here (upstream), and let you guys accept the changes upstream at your own pace - am annoying enough about the pkg build 😁 🍺

@valeriupredoi
Copy link
Author

I have opened #645 for upstream deps and a DNMY PR at the feedstock conda-forge/prospector-feedstock#44 that should wait for the upstream one - in the meantime I've realized that flake8>=6 will mean loss of support for Python 3.7 which is up to you guys to decide if can be done or not. At any rate, let me know if I can do anything else, and have a good weekend in the meantime 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants