Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative gem dependency for JRuby: json-jruby rather than json #16

Closed
mjtko opened this issue Feb 19, 2010 · 3 comments
Closed

Alternative gem dependency for JRuby: json-jruby rather than json #16

mjtko opened this issue Feb 19, 2010 · 3 comments

Comments

@mjtko
Copy link

mjtko commented Feb 19, 2010

To allow couch_potato to work within JRuby, please could you add a dependency on the 'json-jruby' gem rather than the 'json' gem if JRUBY_VERSION is non-nil?

I'm afraid I'm not certain of the necessary steps to get this to work with Jeweler and its magical gemspec creation - I modified the Rakefile for my own purposes prior to a 'rake install' but, of course, this won't work for a distributed gem.

@langalex
Copy link
Owner

sorry neither do i. i guess this will have to wait until someone picks this up.

@mjtko
Copy link
Author

mjtko commented Feb 19, 2010

Ok, I'll endeavour to get my head around it and supply an appropriate push request!

Just didn't want to fork etc if it was a simple job for you! :-)

@mjtko
Copy link
Author

mjtko commented Feb 23, 2010

I made the assumption that this would be dealt with in a sensible fashion by rubygems, but it turns out that platform specific dependency management is not yet a feature. I guess the only way of supporting this sensibly is to roll a platform specific couch_potato gem for the '-universal-java' platform but this isn't something I think I'll get into.

For now, I'll stick with the download and modify Rakefile approach. When rubygems catches up one day I'll revisit this but will close for now.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants