community: DuckDB VS - expose similarity, improve performance of from_texts #20971
+59
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
Ɑ: vector store
hkad98
reviewed
Apr 27, 2024
hkad98
reviewed
Apr 27, 2024
jaceksan
force-pushed
the
duckdb
branch
2 times, most recently
from
afc56bb
to
b171b58
Compare
leo-gan
reviewed
Apr 28, 2024
|
@baskaryan @eyurtsev should I try to fix the failing test? Any suggestion would be appreciated. |
baskaryan
reviewed
May 2, 2024
dosubot
bot
added
size:XXL
dosubot
bot
added
size:M
hwchase17
reviewed
May 9, 2024
|
@hwchase17 can we merge it now? |
Row-by-row INSERTs are not recommended by the official DOC. They are very slow and utilize heavily the storage. I tested it with 100+ documents, duration went down from 27s to 7s and local SSD is far less utilized.
jaceksan
force-pushed
the
duckdb
branch
2 times, most recently
from
a65c58c
to
6275223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 fixes of DuckDB vector store:
vector_key).from_documentsDependencies: added Pandas to speed up
from_documents.I was thinking about CSV and JSON options, but I expect trouble loading JSON values this way and also CSV and JSON options require storing data to disk.
Anyway, the poetry file for langchain-community already contains a dependency on Pandas.