-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specifying commit hash in hub.pull
is not working
#4289
Comments
hub.pull
is not workinghub.pull
is not working
🤖 Thank you for bringing this to our attention. Based on the provided context, it seems that the The commit hash is handled in the /**
* Fetches the files from a GitHub repository.
* If the path denotes a single file, the resulting array contains only one element.
* @param path The path of the repository to fetch the files from.
* @returns A promise that resolves to an array of GithubFile instances.
*/
private async fetchRepoFiles(path: string): Promise<GithubFile[]> {
const url = `${this.apiUrl}/repos/${this.owner}/${this.repo}/contents/${path}?ref=${this.branch}`;
return this.caller.call(async () => {
this.log(`Fetching ${url}`);
const response = await fetch(url, { headers: this.headers });
const data = await response.json();
if (!response.ok) {
throw new Error(
`Unable to fetch repository files: ${
response.status
} ${JSON.stringify(data)}`
);
}
if (Array.isArray(data)) {
return data as GithubFile[];
} else {
return [data as GithubFile];
}
});
} In this method, However, without the actual implementation of the To help us investigate this further, could you please provide more information about how you're using the SourcesThis response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot. |
Hmm I'm seeing this issue too, not good. Will investigate now! |
I've identified a fix and it will be released soon! I'll update you here once we update the |
Description
For example, these two should be different:
But the result is the same.
A simple reproduction
Note that the python SDK is working, but in the JavaScript SDK it seems specifying a commit hash is useless. I don't know why.
The text was updated successfully, but these errors were encountered: