Programmatic reference construction #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,7 +60,7 @@ export class DefaultReferencesProvider implements ReferencesProvider { | |||
| if (targetAstNode) { | |||
| const options = { includeDeclaration: params.context.includeDeclaration }; | |||
| this.references.findReferences(targetAstNode, options).forEach(reference => { | |||
| if (isReference(reference)) { | |||
| if (isReference(reference) && reference.$refNode) { | |||
There was a problem hiding this comment.
Question: In which cases will a ReferenceDescription be a proper Reference. Is this legacy?
There was a problem hiding this comment.
Probably yes, I'll remove it.
After removing the code you found above, there was only one use site remaining, so I didn't add this for now. |
sailingKieler
approved these changes
Dec 6, 2022
It's a pattern to convert something into a Boolean value, but double negation is always harder to understand than a direct statement ("I wouldn't say that noone has done it" vs. "Someone has done it"). |
|
Similar: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #773. The
$refNodeproperty is made optional so programmatic construction of (partial) ASTs with references is easier.