Further reworks of the documents loading… #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
approved these changes
Dec 7, 2022
sailingKieler
force-pushed
the
cd-801-follow-up
branch
from
76cf415
to
9a9f191
Compare
sailingKieler
force-pushed
the
cd-801-follow-up
branch
from
9a9f191
to
b58988c
Compare
sailingKieler
commented
Dec 9, 2022
| * Create a Langium document for the given URI. The document shall be fetched from the {@link TextDocuments} | ||
| * service if present, and loaded via the configured {@link FileSystemProvider} otherwise. | ||
| */ | ||
| create<T extends AstNode = AstNode>(uri: URI): LangiumDocument<T> |
There was a problem hiding this comment.
I removed the additional optional content parameter that was in here in my first draft.
IMO this justifies the presence of the 'from...' methods much better, the document builder needs just this, and everything below is just implementation detail of DefaultLangiumDocumentFactory.
@spoenemann @msujew Do you agree?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to concentrate accesses the TextDocuments and FS in the 'LangiumDocumentFactory'
followup on #788, #801