EnglishSynthesizer makes word lowercase

[danielnaber]

This code in lookup lowercases the word, even if determiner is empty:

results.add(determiner + StringTools.lowercaseFirstCharIfCapitalized(result));

Fixing this by adding in if makes the test for AGREEMENT_SENT_START[34] ("Cats sleeps more than 15 hours per day.") fail, probably due to some bug in PatternRuleMatcher.formatMatches().

[ChristinaLJC]

Hi, I'd like to try on this issue.

[ChristinaLJC]

I am confused that why "results.add(determiner + StringTools.lowercaseFirstCharIfCapitalized(result));" has been commented out. Is it already fixed?

[ChristinaLJC]

And I am also confused about "the test for AGREEMENT_SENT_START[34]" you mentioned. Can you tell me where the test is?

[danielnaber]

And I am also confused about "the test for AGREEMENT_SENT_START[34]" you mentioned. Can you tell me where the test is?

It's the 34th <rule> in <rulegroup id="AGREEMENT_SENT_START">...</rulegroup> in en/grammar.xml (or it was when I created the issue).

[ChristinaLJC]

Oh! It seems that it is no need to fix it now