Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smart quotes for all languages #7012

Open
marcoagpinto opened this issue Aug 12, 2022 · 2 comments
Open

Use smart quotes for all languages #7012

marcoagpinto opened this issue Aug 12, 2022 · 2 comments

Comments

@marcoagpinto
Copy link
Member

Hi!

I have been using the browser add-on for English and Portuguese.

While using English, it shows an option to change all quotes in the text.

But, in Portuguese, that doesn't seem to happen.

Could it be extended to all languages?

Thanks!

@Tex2002ans
Copy link
Contributor

Wikipedia's "Quotation Marks" > Summary Table is fantastic, showing all:

  • open/close
  • inner/outer

quotes for all languages + their acceptable alternates.


For example, British English prefers:

  • ‘outer’ + “inner”
  • single / double

but accepts:

  • “outer” + ‘inner’
  • double / single

as an alternate, where US English only accepts the 2nd version.


There should probably be a separate settings page where users could select which sets of quotes they prefer.

For example, one "dialogue checking" plugin I use has:

Quotation Mark Settings

I think a settings page like that would cover nearly all use-cases. :)

So even if you were in English (or Portuguese), you would be able to override the language's default quotes if needed.

@marcoagpinto
Copy link
Member Author

Hello, after 5 months still no development.

Take a look at how it works in English GB:
smart_quotes_lt_20230101

Could this exactly code be used for Portuguese?

It is very “painful” to be fixing quote by quote manually.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants