Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback from systemd to schedule next wake up on manual suspend #43

Closed
languitar opened this issue Jul 29, 2018 · 3 comments · Fixed by #66
Closed

Callback from systemd to schedule next wake up on manual suspend #43

languitar opened this issue Jul 29, 2018 · 3 comments · Fixed by #66
Assignees
Milestone

Comments

@languitar
Copy link
Owner

Currently, if someone manually suspends the system, nothing will ensure that autosuspend has set the next alarm to wake up the system. Thus, activities might be missed.

The existing systemd integration has to be change to call a special-purpose command that handles manual suspends by adding the wake up logic.

@languitar languitar modified the milestones: 2.0, 2.1 Jul 29, 2018
@languitar languitar self-assigned this Aug 25, 2018
@nioncode
Copy link
Contributor

nioncode commented Aug 4, 2019

I propose to completely remove the current wakeup handling and instead add a systemd service that runs whenever the system goes to sleep. When this service runs, autosuspend can check which is the next wakeup event and schedule it.

@languitar
Copy link
Owner Author

That was the plan of this issue and its more or less implemented. I just didn't find the time to finish the branch.

@languitar
Copy link
Owner Author

@nioncode I have rebase the old branch to be up to date with the master changes. I will not be able to remove the complete wakeup handling from the main checking loop though, because I do not want to trigger a suspend in case the system has to wake up again in just a few seconds (a configurable delta).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants