Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 'pmult' and 'qmult' csv data are not being parsed correctly in multinetwork test cases. #386

Closed
juanjospina opened this issue Mar 31, 2022 · 0 comments · Fixed by #387
Labels
Category: Data Parsers parser issues good first issue Type: Bug Something isn't working

Comments

@juanjospina
Copy link
Contributor

Describe the bug

When running multinetwork tests with loadshapes, the option to add pmult and qmult as separate csv files is not working correctly. What is happening is that the qmult data is overwriting the pmult data in the _dss2eng_loadshape!(...) function.

Minimum Viable Example

If you have an example test case where you are adding a loadshape as follows:

New Loadshape.ls1 npts=4 pmult=(file=load_profile_case3_p1.csv) qmult=(file=load_profile_case3_q1.csv)

and the data inside the files are:

load_profile_case3_p1.csv:
0.3
0.5
0.8
0.7

load_profile_case3_q1.csv:
0.1
0.23
0.12
0.12

You will see that the result is that both P and Q values in the time series will be multiplied by the values in the load_profile_case3_q1.csv file only.

Expected behavior

The expected behavior is that the values P and Q are multiplied by their respective csv file data, pmult and qmult respectively.

Screenshots
N/A.

System Information (please complete the following information):

  • OS: Ubuntu 20.04 LTS
  • Version: 0.14.3 (latest main version)

Additional context
One way to solve the problem (checked by me) is to make a deepcopy of the eng_obj in the function _dss2eng_loadshape!(...) as follows:

image

This will make sure that the data of pmult is not overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Data Parsers parser issues good first issue Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants