Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test for simulate_de #45

Closed
zmorrell opened this issue May 22, 2024 · 0 comments · Fixed by #48
Closed

Fix failing test for simulate_de #45

zmorrell opened this issue May 22, 2024 · 0 comments · Fixed by #48
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zmorrell
Copy link
Collaborator

The current CI build is failing 2 tests as a result OrdinaryDiffEq.jl's update to version 6.78.0. The unit tests should be evaluated and adapted to ensure that the simulate_de function is still functioning properly as a result of their recent changes. It is possible that either more stringent default error tolerances will need to be introduced for the simulate_de function or the baseline will need to be adapted.

The update makes the output value from simulate_de differ from the benchmark value by ~1e-6, so most standard user functionality that does not require high precision should be largely un-impacted.

@zmorrell zmorrell added bug Something isn't working good first issue Good for newcomers labels May 22, 2024
@zmorrell zmorrell self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant