Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around random.choices #43

Closed
ccoffrin opened this issue Jul 5, 2019 · 3 comments
Closed

Work around random.choices #43

ccoffrin opened this issue Jul 5, 2019 · 3 comments
Assignees
@yuchenpang

Comments

@ccoffrin
Copy link
Member

ccoffrin commented Jul 5, 2019

This function is not supported in python 3.5, we should work around it so that the code is more portable.
@yuchenpang
Copy link
Collaborator

This function is not supported in python 3.5, we should work around it so that the code is more portable.

Is it okay to use NumPy? I saw it in requirements.txt but it's not actually used in the code yet. If yes, numpy.random.choice might be a good replacement.

@ccoffrin
Copy link
Member Author

ccoffrin commented Jul 8, 2019

I would prefer not to, NumPy has C bindings that can create installation issues. It is in the requirements because an upstream dependency uses it.

@ccoffrin
Copy link
Member Author

closes by #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuchenpang yuchenpang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ccoffrin @yuchenpang