inscell uninitialized

[jordisanglas]

For some reason, this bug only happens if dfnTrans is compiled without the -O6 optimization flag.

In the function NeighborCells(), inscell is not initialized to 0. It might happen that, in the first step of the do while loop, the condition inside the if statement is not fulfilled for any of the 4 steps of the for loop (this can happen when the particle is in a cell in contact with an intersection). In that case, the program finishes the first step of the do while loop with inscell uninitialized. Therefore, the condition inscell==0 is evaluated using an incorrect value for inscell. As a consequence, the loop might finish earlier than expected.

This bug has the result that many particles get lost (tested with the truncated_power_law_dist test, without the -O6 compilation flag). Adding inscell=0 at the beginning of the function solves this issue.