Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type checking in workflows #170

Closed
bwohlberg opened this issue Jan 11, 2022 · 0 comments · Fixed by #176
Closed

Type checking in workflows #170

bwohlberg opened this issue Jan 11, 2022 · 0 comments · Fixed by #176
Labels
developer Developer environment: issues related to CI, git, etc. enhancement New feature or request typing Related to type annotations

Comments

@bwohlberg
Copy link
Collaborator

bwohlberg commented Jan 11, 2022 •
edited
Loading

Since we're going to the effort of adding type annotations to the code, it would make sense to enable type checking in the github workflows to avoid the accumulation of type errors or errors in these annotations.
@bwohlberg bwohlberg added enhancement New feature or request developer Developer environment: issues related to CI, git, etc. labels Jan 11, 2022
@bwohlberg bwohlberg changed the title Type checking in workflow Type checking in workflows Jan 11, 2022
@bwohlberg bwohlberg linked a pull request Jan 14, 2022 that will close this issue
Fix typing errors and set up mypy workflow action #176
Merged
@bwohlberg bwohlberg added the typing Related to type annotations label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer Developer environment: issues related to CI, git, etc. enhancement New feature or request typing Related to type annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typing errors and set up mypy workflow action lanl/scico
1 participant
@bwohlberg