Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADMM initializer supports setting f=None #376

Open
bwohlberg opened this issue Jan 5, 2023 · 1 comment
Open

ADMM initializer supports setting f=None #376

bwohlberg opened this issue Jan 5, 2023 · 1 comment
Assignees
@Michael-T-McCann
Labels
discussion required Some discussion necessary to decide how to address this issue documentation Improvements or additions to documentation

Comments

@bwohlberg
Copy link
Collaborator

While not documented, the ADMM class __init__ supports setting f=None. This capability is used in several example scripts, e.g.

scico/examples/scripts/denoise_l1tv_admm.py

Lines 62 to 64 in 029a595

solver = ADMM(
f=None,
g_list=[g_loss, g_tv],

This support should either be documented or removed. The latter is perhaps cleaner since the same effect can be achieved by setting f to a ZeroFunctional object.
@bwohlberg bwohlberg added documentation Improvements or additions to documentation discussion required Some discussion necessary to decide how to address this issue labels Jan 5, 2023
@bwohlberg
Copy link
Collaborator Author

bwohlberg commented May 8, 2023 •
edited by Michael-T-McCann

Agreement reached to remove support for f = None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Michael-T-McCann Michael-T-McCann

Labels
discussion required Some discussion necessary to decide how to address this issue documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwohlberg @Michael-T-McCann