fixes #478 (#481)

* fixes #478
lanpa · Aug 5, 2019 · 366bc8f · 366bc8f
1 parent b5ab572
commit 366bc8f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/tensorboardX/summary.py b/tensorboardX/summary.py
@@ -69,6 +69,7 @@ def _draw_single_box(image, xmin, ymin, xmax, ymax, display_str, color='black',
 def hparams(hparam_dict=None, metric_dict=None):
     from tensorboardX.proto.plugin_hparams_pb2 import HParamsPluginData, SessionEndInfo, SessionStartInfo
     from tensorboardX.proto.api_pb2 import Experiment, HParamInfo, MetricInfo, MetricName, Status
+    from six import string_types
 
     PLUGIN_NAME = 'hparams'
     PLUGIN_DATA_VERSION = 0
@@ -94,7 +95,17 @@ def hparams(hparam_dict=None, metric_dict=None):
 
     ssi = SessionStartInfo()
     for k, v in hparam_dict.items():
-        ssi.hparams[k].number_value = v
+        if isinstance(v, string_types):
+            ssi.hparams[k].string_value = v
+            continue
+
+        if isinstance(v, bool):
+            ssi.hparams[k].bool_value = v
+            continue
+
+        if not isinstance(v, int) or not isinstance(v, float):
+            v = make_np(v)[0]            
+            ssi.hparams[k].number_value = v
 
     content = HParamsPluginData(session_start_info=ssi, version=PLUGIN_DATA_VERSION)
     smd = SummaryMetadata(plugin_data=SummaryMetadata.PluginData(plugin_name=PLUGIN_NAME,

diff --git a/tests/test_summary.py b/tests/test_summary.py
@@ -127,4 +127,7 @@ def test_hparams(self):
     def test_hparams_smoke(self):
         hp = {'lr': 0.1, 'bsize': 4}
         mt = {'accuracy': 0.1, 'loss': 10}
-        summary.hparams(hp, mt)
+        summary.hparams(hp, mt)
+
+        hp = {'string': "1b", 'use magic': True}
+        summary.hparams(hp, mt)