fix issue with hparams logging to Comet (#626)

* fix issue with hparams logging to Comet

* fix linting with autopep8

* update README with comet links

* update utms in Comet link

README.md

@@ -100,6 +100,16 @@ writer.close()
 
 <img src="screenshots/Demo.gif">
 
+## Using TensorboardX with Comet
+
+TensorboardX now supports logging directly to [Comet](https://www.comet.ml/site/data-scientists/?utm_campaign=tensorboardx-integration&utm_source=github&utm_medium=readme). Comet is a **free** cloud based solution that allows you to automatically track, compare and explain your experiments. It adds a lot of functionality on top of tensorboard such as dataset management, diffing experiments, seeing the code that generated the results and more.
+
+This works out of the box and just require an additional line of code. See a full code example in this [Colab Notebook](https://colab.research.google.com/drive/1cTO3tgZ03nuJQ8kOjZhEiwbB-45tV4lm?usp=sharing)
+
+<p align="center">
+<img src="screenshots/comet.gif" width="750" height="400">
+</p>
+
 ## Tweaks
 
 To add more ticks for the slider (show more image history), check https://github.com/lanpa/tensorboardX/issues/44 or 

tensorboardX/writer.py

@@ -40,6 +40,7 @@
 class DummyFileWriter(object):
     """A fake file writer that writes nothing to the disk.
     """
+
     def __init__(self, logdir):
         self._logdir = logdir
 
@@ -400,12 +401,12 @@ def add_hparams(
             name = str(time.time())
 
         with SummaryWriter(logdir=os.path.join(self.file_writer.get_logdir(), name)) as w_hp:
-            w_hp.comet_logger.log_parameters(hparam_dict, step=global_step)
             w_hp.file_writer.add_summary(exp)
             w_hp.file_writer.add_summary(ssi)
             w_hp.file_writer.add_summary(sei)
             for k, v in metric_dict.items():
                 w_hp.add_scalar(k, v, global_step)
+        self.comet_logger.log_parameters(hparam_dict, step=global_step)
 
     def add_scalar(
             self,