Release 2.4.1 (#649)

* prepare for release * add test case to reproduce #639 * fix description
lanpa · Dec 19, 2021 · b9cea7b · b9cea7b
1 parent 054f1f3
commit b9cea7b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -1,5 +1,9 @@
 History
 =======
+2.4.1 (2021-11-20)
+-------------------
+* Fix a comet plugin bug if writer is reused. (#639)
+
 2.4 (2021-06-30)
 -----------------
 * Remove a dependency issue. (#631)

diff --git a/setup.py b/setup.py
@@ -32,7 +32,7 @@ def run(self):
     history = history_file.read()
 
 preparing_PyPI_package = 'sdist' in sys.argv or 'bdist_wheel' in sys.argv
-version_git = version = '2.4'
+version_git = version = '2.4.1'
 
 if not preparing_PyPI_package:
     if os.path.exists('.git'):
@@ -96,5 +96,4 @@ def run(self):
 # git commit -m 'prepare for release'
 # add tag
 # twine upload dist/*
-# git push
-
+# git push -u origin HEAD
diff --git a/tests/test_writer.py b/tests/test_writer.py
@@ -71,6 +71,12 @@ def test_flush(self):
     def test_auto_close(self):
         pass
 
+    def test_reuse_writer_after_closed(self):
+        w = SummaryWriter()
+        w.close()
+        w.add_text("reuse writer", "dont reuse without creating a new writer", 0)
+
+
     def test_writer(self):
         with SummaryWriter() as writer:
             sample_rate = 44100