Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for other scalar data types than the builtin 'float' and 'int' #37

Closed
tro4els opened this issue Sep 28, 2017 · 2 comments
Closed

Support for other scalar data types than the builtin 'float' and 'int' #37

tro4els opened this issue Sep 28, 2017 · 2 comments

Comments

@tro4els
Copy link

tro4els commented Sep 28, 2017 •
edited

Would it be possible to use numpy.isscalar(x) to condition on data type in x2num.makenp, or is there a good reason not to? It seems to me that this would simplify the code and add support for numpy.floatXX and numpy.intXX.
@tro4els tro4els changed the title support for other scalar data types than the builtin 'float' and 'int' Support for other scalar data types than the builtin 'float' and 'int' Sep 28, 2017
@lanpa lanpa closed this as completed in 13167bd Sep 28, 2017
@lanpa
Copy link
Owner

lanpa commented Sep 28, 2017

updated. You can use pip install git+https://github.com/lanpa/tensorboard-pytorch to have a test.

@tro4els
Copy link
Author

tro4els commented Sep 29, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lanpa @tro4els