Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cat issue in add_embedding with cuda tensor #58

Closed
apsdehal opened this issue Dec 14, 2017 · 1 comment
Closed

Cat issue in add_embedding with cuda tensor #58

apsdehal opened this issue Dec 14, 2017 · 1 comment

Comments

@apsdehal
Copy link

apsdehal commented Dec 14, 2017

In line number: https://github.com/lanpa/tensorboard-pytorch/blob/master/tensorboardX/embedding.py#L20

If a cuda tensor is passed it will throw an error as torch.randn will generate a cpu tensor and thus both won't be same type. Either throw an explicit warning or check for type of label_img and convert rand tensor accordingly.

I solved it by converting passed tensor to cpu for now.

@apsdehal apsdehal changed the title Cat issue in add_embedding Cat issue in add_embedding with cuda tensor Dec 14, 2017
@lanpa
Copy link
Owner

lanpa commented Dec 15, 2017

Thanks, this reminds me that the 'dirty fix' in make_sprite can be removed :)
Please leave this issue opened. So I wont forget it.

@lanpa lanpa closed this as completed in 69abb00 Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants