Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Read.me #192

Merged
merged 2 commits into from Jun 27, 2016
Merged

Update Read.me #192

merged 2 commits into from Jun 27, 2016

Conversation

GeoffreyEmery
Copy link
Contributor

Description

Extended the README / documentation
you had limit and it should have been the variable should be slice. Also added a start variable and added that call to the slice funciton

Checklist

  • [x ] Code compiles correctly
  • [x ] Created tests which fail without the change (if possible)
  • [ x] All tests passing
  • [ X] Extended the README / documentation, if necessary
  • [x ] Added myself / the copyright holder to the AUTHORS file

you had limit and it should have been the variable should be slice. Also added a start variable and added that call to the slice funciton
@coveralls
Copy link

coveralls commented Jun 25, 2016

Coverage Status

Coverage remained the same at 96.199% when pulling 5869585 on GeoffreyEmery:patch-1 into 06e1785 on lapwinglabs:master.

just changed limit to end to be more like the spec.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.199% when pulling 6be99bc on GeoffreyEmery:patch-1 into 06e1785 on lapwinglabs:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 25, 2016

Coverage Status

Coverage remained the same at 96.199% when pulling 6be99bc on GeoffreyEmery:patch-1 into 06e1785 on lapwinglabs:master.

@matthewmueller matthewmueller merged commit 61ecae6 into matthewmueller:master Jun 27, 2016
@matthewmueller
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants