Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dinghy use thd port 443 and 80, so nginx service will not start #1149

Closed
0xuhe opened this issue Sep 22, 2017 · 8 comments
Closed

dinghy use thd port 443 and 80, so nginx service will not start #1149

0xuhe opened this issue Sep 22, 2017 · 8 comments
Labels

Comments

@0xuhe
Copy link
Contributor

0xuhe commented Sep 22, 2017

Info:

  • Docker version ($ docker --version): Docker version 17.06.0-ce, build 02c1d87
  • Laradock commit ($ git rev-parse HEAD): 53b7f75
  • System info (Mac, PC, Linux): Mac
  • System info disto/version: 12.12.6

Issue:


Expected behavior:


Reproduce:


Relevant Code:

// place a code sample here
@NickToony
Copy link
Contributor

Specific error message:

ERROR: for nginx  Cannot start service nginx: driver failed programming external connectivity on endpoint laradock_nginx_1 (f52fbd0008270eabb0b6375119264fcc19d8dce0bc5a6aa93433ada054aaae5c): Bind for 0.0.0.0:443 failed: port is already allocated
ERROR: Encountered errors while bringing up the project.

@NickToony
Copy link
Contributor

As a workaround:

  1. Shut down dinghy if it's running (dinghy halt)
  2. Edit the dinghy config, ~/.dinghy/preferences.yml, and change proxy_disable to true
  3. Save and boot dinghy back up (dinghy up)
  4. Boot up laradock the normal way

Your laradock app will be available at http://web.myapp.docker/.

This is a good enough solution for me currently, though maybe someone can figure out a proper fix.

@idflood
Copy link

idflood commented Nov 12, 2018

I confirm this is still an issue, also visible when using apache2 instead of nginx. I didn't find a solution yet and I am also wondering how to connect from host to mysql for instance. With sequel pro I can connect to 127.0.0.1:3306 when not using dinghy, but with it it doesn't work with the same host/port.

@idflood
Copy link

idflood commented Nov 13, 2018

So I've finally been playing with docker native NFS support on osx following this guide https://medium.com/@sean.handley/how-to-set-up-docker-for-mac-with-native-nfs-145151458adc . And I have to say that I've seen a massive performance boost and this new method is "easier" to setup.

I think that the documentation could be updated to at least mention this possibility and provide instructions about how to setup this. I will try to fork the laradock repository to have a diff of the changes made to the .env (local) and docker-compose file.

@idflood
Copy link

idflood commented Nov 14, 2018

I did a quick benchmark before going further, and the good news is that it confirm the feeling that using NFS setup is nearly like "native", sometimes even faster (php config, opcache or other settings may explain this.

Fresh Drupal 8 install, most caches including the Twig cache are disabled.
Visiting /admin/config, measuring time needed for html load.

MAMP (PHP 7.2.8)
~520ms

Docker (laradock default config)
between ~1500ms

Docker (with native osx NFS volume)
~450ms

@idflood
Copy link

idflood commented Nov 14, 2018

So here is the fork with the changes required on laradock to use NFS volume: idflood@cad44b5

Note that you also need to run the script from https://medium.com/@sean.handley/how-to-set-up-docker-for-mac-with-native-nfs-145151458adc to setup nfs file sharing correctly.

@stale
Copy link

stale bot commented Feb 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Feb 2, 2020
@stale
Copy link

stale bot commented Feb 23, 2020

Hi again 👋 we would like to inform you that this issue has been automatically closed 🔒 because it had not recent activity during the stale period. We really really appreciate your contributions, and looking forward for more in the future 🎈.

@stale stale bot closed this as completed Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants