afterCreating method does not accept Closure(Model)

[Batisska]

• Larastan Version: 2.0.0
• --level used: 8

Description

Every time I call afterMaking or afterCreating phpstan crashes with an error.

Laravel code where the issue was found

    /**
     * @return TaskFactory
     */
    public function configure(): TaskFactory
    {
        return $this->afterCreating(function (Task $task) {
            $task->assigned()->attach(User::factory()->count(5)->create());
            $task->files()->attach(File::factory()->count(5)->create());
        });
    }

Parameter #1 $callback of method Illuminate\Database\Eloquent\Factories\Factory<Illuminate\Database\Eloquent\Model>::afterCreating() expects 
    Closure(Illuminate\Database\Eloquent\Model): mixed,
    Closure(App\Data\Models\Task): void given.    

[szepeviktor]

Hello Сергей! 👋

Thank you for your report.
I see two possible solutions.
Does Task extend Model?
What if you return something?

[Batisska]

Yes Task extends the Model.

If you return the Task, the same error.

[szepeviktor]

Thank you!
It is a bug.

[szepeviktor]

No. We need generics!

/**
 * @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Data\Models\Task>
 */
class TaskFactory extends Factory
{

But I cannot get it working.

[Batisska]

No. We need generics!

/**
 * @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Data\Models\Task>
 */
class TaskFactory extends Factory
{

But I cannot get it working.

What information can I provide you? To understand where the bug crept in? Thank you.

Generic did not help.

[szepeviktor]

@canvural Can you help us? We are a bit lost.

[canvural]

Hello,

The types are coming from Laravel itself. So I suggest opening an issue there.

A solution would be to change the type here to just \Closure(TModel): mixed Since TModel is bound to EloquentModel anyway, there is no need of an union type. I think that would resolve the issue.

Also instead of an issue you can directly create a PR there. Feel free to link this issue or this comment.

Thanks.

[mdpoulter]

@canvural It looks like Laravel won't be making that change in the near future, as the delay is IDE support (laravel/framework#41286). Is this something which Larastan can support in the meantime?

[canvural]

@mdpoulter Yeah, I guess we can do that. It should be added to this stub file.