Default date field casts are ignored

[john-dent]

Readable / writable type for Laravels default date columns ignores any model casts.

Can be replicated by casting updated_at, created_at or deleted_at; you will notice larastan does not respect the cast.

Our specific use case is to return an array of formatted dates, larastan still expects the return type to be of Carbon|null.

I can create a PR for this issue that would first respect the cast and fallback to the default date format, if this is something that may be approved?

Many thanks,

[szepeviktor]

Hello @john-dent 👋🏻
Thank you for your report and offer.

Our specific use case is to return an array of formatted dates

Could you show us in code how you do that?

[john-dent]

Could you show us in code how you do that?

Sure, something along the lines of the following in a custom cast:

    public function get($model, $key, $value, $attributes)
    {
        return [
            'raw' => $value ?? null,
            'formatted' => $value?->format('jS M Y G:i'),
            'ago' => $value?->diffForHumans(),
        ];
    }

[john-dent]

@szepeviktor

Specific issue appears to be in /src/Properties/ModelPropertyExtension.php Lines 151-154, offhand I think a suitable fix would be as simple as swapping the if and elseif.

https://github.com/nunomaduro/larastan/blob/4ba82ba350e5a5288154454cc069bda6af8b7aba/src/Properties/ModelPropertyExtension.php#L151-L164