Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing refactor #658

Closed
Daanra opened this issue Sep 12, 2020 · 5 comments
Closed

Testing refactor #658

Daanra opened this issue Sep 12, 2020 · 5 comments

Comments

@Daanra
Copy link
Contributor

Daanra commented Sep 12, 2020

Description

Currently, the FeaturesTests that we use do not allow you to assert whether Larastan reports an error for a specific piece of code. Instead, we can only test whether Larastan reports no errors.

It would be if we could add functionality that allows us to assert that Larastan reports certain errors. In addition, it would be nice if we could change Larastan's config during a test such that we can, for example, test functionality that is disabled by default.

Created a separate issue because of this comment

@nunomaduro
Copy link
Collaborator

@Daanra You already have permissions to maintain this package right?

@Daanra
Copy link
Contributor Author

Daanra commented Sep 12, 2020

@Daanra You already have permissions to maintain this package right?

@nunomaduro I do have write permissions for this repository, if that's what you meant.

I could take a stab at this refactor if nobody has any concrete plans for it yet.

@szepeviktor
Copy link
Collaborator

szepeviktor commented Sep 12, 2020

concrete plans

kép

@canvural
Copy link
Collaborator

canvural commented Oct 7, 2020

I'd like to use the TestCase classes from PHPStan. The only problem I see is we need to bootstrap Laravel with testbench before starting the tests. If we can solve it we can use this approach I think.

@nunomaduro
Copy link
Collaborator

I am also not happy with the current test suite. Feel free to make a pull request to improve this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants