Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading indicators heavily impact diffing performance #5210

Closed
pxlrbt opened this issue Dec 8, 2022 · 2 comments
Closed

Loading indicators heavily impact diffing performance #5210

pxlrbt opened this issue Dec 8, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pxlrbt
Copy link
Member

pxlrbt commented Dec 8, 2022

Package

filament/tables

Package Version

v2.x

Laravel Version

Any

Livewire Version

Any

PHP Version

Any

Problem description

When filtering/updating tables with large datasets the tables' loading indicators cause massive performance issues, sometimes taking a 800ms request up to 10s in total time. A reload is faster than request via Livewire.

250 records with 4 columns will result in 1000 loading indicators.

Example: Filtering 292 items to 41 items:

Bildschirmaufnahme.2022-12-08.um.15.08.02.mov

Expected behavior

Faster loading:

Bildschirmaufnahme.2022-12-08.um.15.07.02.mov

Steps to reproduce

  • Large table with > 100/200 entries.
  • Filter from All to a small set

Reproduction repository

2 private repos available from me and "hmihail"

Relevant log output

No response

@pxlrbt pxlrbt added bug Something isn't working unconfirmed labels Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Hey @pxlrbt! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2022
@pxlrbt pxlrbt reopened this Dec 8, 2022
@pxlrbt pxlrbt self-assigned this Dec 8, 2022
@pxlrbt pxlrbt added this to the v2 milestone Dec 8, 2022
@danharrin
Copy link
Member

Closing as stale.

@danharrin danharrin closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants