Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to install a localization from laravel-lang/lang ? #200

Closed
realtebo opened this issue Jan 14, 2022 · 8 comments
Closed

How to install a localization from laravel-lang/lang ? #200

realtebo opened this issue Jan 14, 2022 · 8 comments

Comments

@realtebo
Copy link

realtebo commented Jan 14, 2022

  • Lang Publisher Version: 11.1.5
  • Laravel Version: 8.79.0
  • PHP Version: 7.4

Description:

How to install italian locale?

I have installed both

    "laravel-lang/lang": "~8.0",
    "laravel-lang/publisher": "^11.1",

I want to simply install/expose/use italian localizations

I am not able to do understand how to do

Steps To Reproduce:

I also tried a locale:add it but it creates new empty file for italian locales

I tried also running locale:update but nothing changes

@mohamedsabil83
Copy link
Member

Don't install both of them as laravel-lang/publisher install the proper version of laravel-lang/lang under the hood. maybe that causes the issue.
try to remove laravel-lang/lang

@realtebo
Copy link
Author

realtebo commented Jan 14, 2022

I read in the doc here:; https://laravel-lang.github.io/publisher/using/plugins/index.html

Install the package into your application. For example, composer require laravel-lang/lang --dev

I removed vendor
I removed explicit dev dependency of laravel-lang/lang
I run composer:upgrade

Installed these

Downloading laravel-lang/lang (10.1.12)
Downloading laravel-lang/publisher (v11.1.12)

I run php artisan locale:add it

It worked

There is something wrong in the laravel-lang/lang installation instructions.

This page: https://laravel-lang.github.io/lang/installation/composer.html

Should tell users to do not use it directly, and also should have version numbers updated.

@andrey-helldar
Copy link
Member

@realtebo, I'll update the documentation soon :)

The https://laravel-lang.github.io/lang/installation/composer.html documentation describes the installation process without a publisher

@realtebo
Copy link
Author

It could be usefull to say: install THEN manually copy files :)

@andrey-helldar
Copy link
Member

@realtebo, in version 11.1.5 I wanted to remove the lang package from the publisher, but in patch 11.1.6 I brought it back.

Just run composer update.

@andrey-helldar
Copy link
Member

andrey-helldar commented Jan 14, 2022

It could be usefull to say: install THEN manually copy files :)

https://laravel-lang.github.io/lang/installation/files.html :)

image

@realtebo
Copy link
Author

Please, don't hate me. It's only that install in the 'list' mode tells user that must choose one of 4 methods

nothing helps user to understand that AFTER installing using composer/github/svn must always copy files.
I suggest to replace the list and 5 pages with a more clear and simple paragraph. Just and idea.

@andrey-helldar
Copy link
Member

andrey-helldar commented Jan 14, 2022

I agree. Laravel-Lang/lang#1942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants