Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.*] Combine not working #2624

Closed
thisisjamessmith opened this issue Nov 23, 2020 · 5 comments · Fixed by #3115
Closed

[6.*] Combine not working #2624

thisisjamessmith opened this issue Nov 23, 2020 · 5 comments · Fixed by #3115
Assignees
Labels

Comments

@thisisjamessmith
Copy link

Description:

Hiya, thanks for Mix! I'm trying to upgrade to version 6 and finding that combine is not working for me when it was ok in Mix 5. I've put together a fully reduced test repo here demonstrating the issue: https://github.com/cld-agency/mix6-test

The repo contains two CSS files (one SCSS and one plain CSS, though I've tried with two CSS files and using the postCSS command for both, with the same results). I compile them and then combine them into combined.css. The combined.css file gets created but is always blank.

Steps To Reproduce:

  • Laravel Mix Version: 6.0.0-beta.14
  • Node Version: 14.15.0
  • NPM Version: 6.14.8
  • OS: MacOS 10.15.7

When doing npm install I do get a deprecation warning - not sure if this has any bearing on the issue, but I can't find a way to make this warning go away!

npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
@JeffreyWay
Copy link
Collaborator

Thanks, I'll have a look this week.

@ezra-obiwale
Copy link

ezra-obiwale commented Jan 29, 2021

@JeffreyWay Any updates on this, please? Still doesn't work as of 6.0.11.

@PawelDmochowski
Copy link

@JeffreyWay

This actually does work but incorrectly.
combine/styles is executed in parallel to sass/less/etc.
As a result the concatenated file is empty or only contains any pre-built/static content.
In the provided repro if the files were not cleaned after concatenation then second run of mix would provide correct results.
But in that case cleaning up is not possible...

@maiconmva
Copy link

+1

upgraded to latest version and broken my script!!

i cant compile and after that combine

@stale
Copy link

stale bot commented Jun 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants