Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I pass options into minify() or version()? #383

Closed
phanan opened this issue Feb 15, 2017 · 2 comments
Closed

How do I pass options into minify() or version()? #383

phanan opened this issue Feb 15, 2017 · 2 comments

Comments

@phanan
Copy link

phanan commented Feb 15, 2017

  • Laravel Mix Version: 0.7.4
  • Node Version: v6.9.1
  • NPM Version: 3.10.8
  • OSX El Capitan

Description:

(Sorry if this isn't the proper platform for these questions).

I'm using plyr in one of my projects. To my surprise, the styles applied on my local version

image

are quite different from their production counterpart:

image

I dug a bit deeper into the code and, apparently, all those ::-webkit-progress-* styles aren't applied on production somehow, resulting in the default green background. Further explorations reveal clean-css has a bug that can be worked around with { restructuring: false }. Now how do I pass this configuration into minify() or version() and see if it works? I don't see an option to customize the two functions' settings. Oddly enough, directly modifying Mix's source files and passing the option doesn't work – the code isn't even reached.

@JeffreyWay
Copy link
Collaborator

It looks like we're using the v3 version of clean-css, and they fixed your issue for v4. So I'm going to upgrade that dependency and tag it today.

@phanan
Copy link
Author

phanan commented Feb 16, 2017

Confirmed this fixed the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants