Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No one notifications are not sent if one of push_token is wrong #44

Closed
dev31 opened this issue Mar 13, 2018 · 3 comments
Closed

No one notifications are not sent if one of push_token is wrong #44

dev31 opened this issue Mar 13, 2018 · 3 comments

Comments

@dev31
Copy link

dev31 commented Mar 13, 2018

function routeNotificationForApn() in the User model returns array of push_tokens.
If the user has array of tokens (several devices), and one of them is wrong - no one devices will be notified.

@dev31
Copy link
Author

dev31 commented Mar 13, 2018

Issue was fixed in v.0.2.1

@dev31 dev31 closed this as completed Mar 13, 2018
@ash-allen
Copy link

Is it confirmed that this was fixed? I'm using v.0.4.0 and I have 5 tokens. My second token is invalid and so the 3rd, 4th and 5th push notifications never get sent.

I've logged the foreach($tokens as $token) loop in ApnChannel.php line 89. And it will only log the first 2 tokens. So it seems like the loop isn't continuing after the failure.

Any ideas? :)

@dwightwatson
Copy link
Collaborator

It may have been broken again - could you test on the latest version? Looks like part of the loop could be throwing an exception on a connection failure that might be the culprit. See if you can work out what's going on from your end and open a new issue with more info so we can sort it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants