Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Launch #1

Open
7 tasks done
atymic opened this issue Feb 20, 2020 · 6 comments
Open
7 tasks done

Channel Launch #1

atymic opened this issue Feb 20, 2020 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@atymic
Copy link
Member

atymic commented Feb 20, 2020

  • Code Review
  • Add to website
  • Create packagist package
  • Travis
  • Style CI
  • Scrutinizer
  • Add badges
@atymic
Copy link
Member Author

atymic commented Feb 20, 2020

Website PR was merged here:
laravel-notification-channels/website#19

@antonkomarev @FunfareNico feel free to tag v1 whenever you are ready (then close this issue).
Would also probably be a good idea to add a notice of depreciation to the old repo, and make the composer package as abandoned.

Thanks!

@antonkomarev
Copy link
Collaborator

I think we need to fix tests first of all, and @FunfareNico was wanted to add attachments to the package.

@antonkomarev
Copy link
Collaborator

antonkomarev commented Feb 21, 2020

@Funfare why did you released v0.1 such early? What's the rush? I'm not sure this package was ready for it. Code style is not finished. Publishing release as soon as you merging PR without any review and answering questions is not that good. I understand that package was under development for a long time, but it would be better to polish it up for a stable public releases.

If you are scary to break application with latest commits to master branch you can always freeze package on exact hash in your application.

@antonkomarev
Copy link
Collaborator

It will be good to switch from TravisCI to GitHub actions workflow.

@antonkomarev antonkomarev added the help wanted Extra attention is needed label Feb 21, 2020
@atymic
Copy link
Member Author

atymic commented Feb 21, 2020

It will be good to switch from TravisCI to GitHub actions workflow.

You have admin privileges on the repo, so you should be able to set that up. Let me know if you run into any issues.

@antonkomarev
Copy link
Collaborator

@atymic could you add me to https://github.com/orgs/laravel-notification-channels/people list, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants