Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added user mocking through Airlock using actingAs #51

Merged
merged 5 commits into from
Jan 21, 2020
Merged

Added user mocking through Airlock using actingAs #51

merged 5 commits into from
Jan 21, 2020

Conversation

leemcd56
Copy link
Contributor

@leemcd56 leemcd56 commented Jan 20, 2020 •
edited

This pull request should resolve issue #50 by adding the requested functionality.

Added

  • Airlock::actingAs with tests for auth:api and abilities

@leemcd56 leemcd56 mentioned this pull request Jan 20, 2020
Closed
@taylorotwell taylorotwell merged commit 6948bb8 into laravel:master Jan 21, 2020
@taylorotwell
Copy link
Member

Both of your tests were broken entirely. Did you run them? I fixed them.

@leemcd56
Copy link
Contributor Author

@taylorotwell I'm sorry about that, I meant to request a review before a merge. The first test worked on my end with no issue, but the second would not. It was saying the personal_access_tokens table did not exist, even though the same setup process was used for GuardTest.php. What was I doing wrong?

@leemcd56
Copy link
Contributor Author

It appears to still be failing with the same issue.

16C05C05-A2A0-40D0-9F20-4F96D07630A8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leemcd56 @taylorotwell