Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of assertIsArray in seeJsonStructure requires phpunit >= 7.5 #120

Closed
katjam opened this issue Feb 17, 2020 · 2 comments
Closed

Use of assertIsArray in seeJsonStructure requires phpunit >= 7.5 #120

katjam opened this issue Feb 17, 2020 · 2 comments
Labels
bug

Comments

@katjam
Copy link

katjam commented Feb 17, 2020 •
edited
Loading

  • Browser Kit Testing Version: 4.2.0
  • Laravel Version: 5.7
  • PHP Version: 7.2
  • Phpunit version 7.0.3

Description:

I haven't taken the time to dive too far into this but hope this can help others with my issue.

The issue is with compatibility with phpunit 7.*

The phpunit assertion assertIsArray is not added until phpunit 7.5

Steps To Reproduce:

Use assertion seeJsonStructure with wildcard *with library versions as above.

Solution:

  • User can: Downgrade browser-kit-testing to <=4.1 or upgrade phpunit to >=7.5
  • browser-kit-testing >4.1 can: require phpunit >=7.5
@katjam katjam changed the title Use of assertIsArray in seeJasonStructure requires phpunit >= 7.5 Use of assertIsArray in seeJsonStructure requires phpunit >= 7.5 Feb 17, 2020
@driesvints
Copy link
Member

You're correct. I'll bump the dependencies. Thanks for reporting this.

@driesvints driesvints added the bug label Feb 17, 2020
@driesvints
Copy link
Member

Will be in tomorrow's release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@driesvints @katjam