Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings about withoutMiddleware() in Laravel 5.5 #44

Closed
sisve opened this issue Jan 26, 2018 · 1 comment
Closed

Warnings about withoutMiddleware() in Laravel 5.5 #44

sisve opened this issue Jan 26, 2018 · 1 comment

Comments

@sisve
Copy link

sisve commented Jan 26, 2018

The change of method signature in laravel/framework@3879cb6 makes the MakesHttpRequests in this package incompatible with the one that comes with laravel/framework.

PHP Warning: Declaration of Laravel\BrowserKitTesting\Concerns\MakesHttpRequests::withoutMiddleware() should be compatible with Illuminate\Foundation\Testing\TestCase::withoutMiddleware($middleware = NULL)

@sisve
Copy link
Author

sisve commented Jan 26, 2018

My fault. The solution is to extend Laravel\BrowserKitTesting\TestCase in the browser-kit tests, not the provided TestCase class in Laravel.

@sisve sisve closed this as completed Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant