Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Travis CI failing on PRs due to confidential env variables not being shared outside repo #37

Closed
sandervanhooft opened this issue Aug 22, 2019 · 4 comments

Comments

@sandervanhooft
Copy link
Collaborator

sandervanhooft commented Aug 22, 2019

Cashier Mollie tests run against Mollie's API.

The credentials for this are stored confidentially in Travis, as to not overload the test account.

The downside of this is that PRs (hosted at the contributor's repo) do not have access to these credentials, and these tests always fail. (See #33 for example).

@sandervanhooft
Copy link
Collaborator Author

FYI @vblinden.

@sandervanhooft
Copy link
Collaborator Author

@willemstuursma do you have a suggestion here? Just open up the credentials?

@willemstuursma
Copy link

Skip the tests if in a PR.

@sandervanhooft
Copy link
Collaborator Author

👍 Good one. Will set up a dev branch as the default.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants