[12.x] Subscription Update Webhook bugfix #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I have to set the Stripe Secret in my fork to run the tests? |
driesvints
changed the title
ends_at; cancel_at field ignored (Custom cancellation date).
No, that's okay. Atm GitHub Actions doesn't share repo secrets. |
|
This lgtm but I'm going to confirm this with someone from Stripe first. I can't find any docs other than the API docs about |
driesvints
approved these changes
Mar 9, 2021
|
Verified that this is indeed the correct solution. Thanks @fschirinzi! |
|
Fyi, I had to add this |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction:
Expected:
ends_atis set as in the stripe subscription model propertycancel_atOutcome:
ends_atproperty in subscription model is null