Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VerifyWebhookSignature middleware. #565

Merged
merged 4 commits into from
Oct 10, 2018
Merged

Add VerifyWebhookSignature middleware. #565

merged 4 commits into from
Oct 10, 2018

Conversation

mcordingley
Copy link
Contributor

This PR addresses #437.

A few notes on this PR:

  • The configuration keys are assumed to exist, as they add on to the keys already defined in services.php in Laravel proper. Assuming this gets merged, those keys will eventually need to be added to that configuration file.
  • The middleware intentionally fails closed. If the user enables this middleware without a web-hook key set, we can assume that the user wants to enforce signatures and that the lack of a key is unintentional.

@taylorotwell taylorotwell merged commit af20559 into laravel:7.0 Oct 10, 2018
gomasy pushed a commit to gomasy/bookshelf that referenced this pull request Oct 19, 2018
gomasy pushed a commit to gomasy/bookshelf that referenced this pull request Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants