Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0 - 1.3.2 - Breaking changes #147

Closed
catalinux opened this issue Aug 25, 2017 · 6 comments
Closed

1.3.0 - 1.3.2 - Breaking changes #147

catalinux opened this issue Aug 25, 2017 · 6 comments

Comments

@catalinux
Copy link

catalinux commented Aug 25, 2017

I think that this changes 7b7dd5f?diff=split added breacking changes.

In 1.3.0 we had following

PHP:

public function broadcastAs()
    {
        return 'alerts\created';
    }

JS:

channel.listen('.alerts.created', (event) => {})

Everything worked great, because EventFormatter would return alerts\created

Now in 1.3.2

when I do channel.listen('.alerts.created', (event) => {}) it will look for alerts.created (that is what EventFormmatter` returns)

Is there a way we could prevent other users to spent hours in debugging. Minor versions should not add breaking changes

@mbarwick83
Copy link

Any update on this? Notifications are no longer working for me, running 1.3.2

@catalinux
Copy link
Author

You have to adapt your event names from php app

@mbarwick83
Copy link

mbarwick83 commented Sep 10, 2017

Thanks. But do you care to elaborate? I'm using echo's notification method.

@ellisio
Copy link
Contributor

ellisio commented Sep 15, 2017

Please refer to PR #140 for why the way you were implementing was actually the broken way. The PR was merged to align the code with the documentation.

@robclancy
Copy link

Lack of a changelog for this makes it risky to update anything.

@ellisio
Copy link
Contributor

ellisio commented Jan 10, 2018

If you followed the Laravel documentation, then you are fine and the risk is minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants