-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.3.0 - 1.3.2 - Breaking changes #147
Comments
Any update on this? Notifications are no longer working for me, running 1.3.2 |
You have to adapt your event names from php app |
Thanks. But do you care to elaborate? I'm using echo's |
Please refer to PR #140 for why the way you were implementing was actually the broken way. The PR was merged to align the code with the documentation. |
Lack of a changelog for this makes it risky to update anything. |
If you followed the Laravel documentation, then you are fine and the risk is minimal. |
I think that this changes 7b7dd5f?diff=split added breacking changes.
In 1.3.0 we had following
PHP:
JS:
Everything worked great, because
EventFormatter
would returnalerts\created
Now in 1.3.2
when I do
channel.listen('.alerts.created', (event) => {})
it will look foralerts.created
(that is what EventFormmatter` returns)Is there a way we could prevent other users to spent hours in debugging. Minor versions should not add breaking changes
The text was updated successfully, but these errors were encountered: