Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define "illuminate/*" dependency requirement #38

Closed
klimov-paul opened this issue Sep 14, 2020 · 1 comment
Closed

Define "illuminate/*" dependency requirement #38

klimov-paul opened this issue Sep 14, 2020 · 1 comment

Comments

@klimov-paul
Copy link

klimov-paul commented Sep 14, 2020

It is hard to tell whether this is intentional or not, but composer.json of this library does not contain any "illuminate/*" library constrait at all.

This might be flexible of course, but it is hard to determine, which Laravel version can match the particular version of this library.

I suggest the following line should be added to the composer.json:

{
    ...
    "require": {
        "illuminate/support": "^7.0 || ^8.0",
        ...
    }
}
@driesvints
Copy link
Member

That's because it's meant to be used in conjunction with Jetstream. But feel free to pr those dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants