New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enter 2FA input token before save model #47
Comments
Gonna mark this as a duplicate of laravel/jetstream#74 to keep the discussion focused. |
understood. But the implementation belongs to fortify in my opinion ;) |
It probably will be. You're always free to attempt a pr if you like 👍 |
ok - will look into this tonight |
At the moment it is impossible to verify that the user activated 2fa in his device.
It should be mandatory that the user has to confirm the activation with an actual 2fa code.
This is not possible at the moment because in "Laravel\Fortify\Actions\EnableTwoFactorAuthentication" the database field is filled on activation. The generation of the secret has to be done before and the secret has to be an option in the action so it is possible to check a valid code before the secret is saved to the database.
related to https://github.com/laravel/jetstream/issues/74
The text was updated successfully, but these errors were encountered: