Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter 2FA input token before save model #47

Closed
jetwes opened this issue Sep 17, 2020 · 4 comments
Closed

Enter 2FA input token before save model #47

jetwes opened this issue Sep 17, 2020 · 4 comments

Comments

@jetwes
Copy link

jetwes commented Sep 17, 2020

At the moment it is impossible to verify that the user activated 2fa in his device.
It should be mandatory that the user has to confirm the activation with an actual 2fa code.
This is not possible at the moment because in "Laravel\Fortify\Actions\EnableTwoFactorAuthentication" the database field is filled on activation. The generation of the secret has to be done before and the secret has to be an option in the action so it is possible to check a valid code before the secret is saved to the database.

related to https://github.com/laravel/jetstream/issues/74

@driesvints
Copy link
Member

Gonna mark this as a duplicate of laravel/jetstream#74 to keep the discussion focused.

@jetwes
Copy link
Author

jetwes commented Sep 17, 2020

understood. But the implementation belongs to fortify in my opinion ;)
I implemented fortify in one of my apps and had to write my own action because with the actual design it's impossible to cache the secret before saving to the database.

@driesvints
Copy link
Member

It probably will be. You're always free to attempt a pr if you like 👍

@jetwes
Copy link
Author

jetwes commented Sep 17, 2020

ok - will look into this tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants