str_slug function ascii character problem

[ozgurkaragoz]

Hi,

I have a problem with ascii characters on laravel 5.2.5 (in Turkish)

(I know 5.2 don't use Stringy)

str_slug('özgür karagöz') => 'oezguer-karagoez'

it must be;

str_slug('özgür karagöz') => 'ozgur-karagoz' (laravel 5.1)

For example in Turkish Language:

'Ö' => 'O',
'ö' => 'o',

in German or etc

'Ö' => 'OE',
'ö' => 'oe',

[GrahamCampbell]

What does laravel 5.1 do with the latest version of stringy?

[GrahamCampbell]

5.2 does use stringy's code. We just copied over the small part of stringy we actually needed and dropped the dependency.

[ozgurkaragoz]

Laravel 5.1 Stringy Version: "danielstjules/stringy": "~1.8"

Actually, this problem Stringy's problem too :)

The latest version of danielstjules/stringy same problem too.

Slugify method must run by locale.

[GrahamCampbell]

Ok then, consider this a breaking change then, but not a bug.

[GrahamCampbell]

If you would like this changed, please send a PR to stringy, and we'll update our code to match what they do each time then tag a release.

[blackfyre]

@ozgurkaragoz You can refer to my blog article on how to fix this issue: https://blackfyre.ninja/blog/fixing-slug-generation-problems