Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented "breaking change" in mail templates #25597

Closed
CodeCooler opened this issue Sep 12, 2018 · 3 comments
Closed

Undocumented "breaking change" in mail templates #25597

CodeCooler opened this issue Sep 12, 2018 · 3 comments

Comments

@CodeCooler
Copy link

CodeCooler commented Sep 12, 2018

  • Laravel Version: 5.7.0

Description:

This appears to be a documentation issue rather than an actual bug.

After updating a 5.6 project to 5.7, I noticed the "Reset Password" button in emails sent to users was not showing up. The reason for this appears to be the change in the "color" options between versions. In 5.7, supported colors are 'primary', 'success', and 'error,' but in 5.6, the options were 'blue,' 'green' and 'red.'

Because I had previously published the vendor files, my 5.6 stylesheet did not contain the new designators, and the buttons did not render properly (screenshots below).

Doing the following within the top project directory did the trick, though:

cp vendor/laravel/framework/src/Illuminate/Mail/resources/views/html/themes/default.css resources/views/vendor/mail/html/themes/default.css

Not a huge deal, but should probably be noted within the 5.6 -> 5.7 upgrade guide.

Steps To Reproduce:

  1. Create a project in 5.6.
  2. php artisan vendor:publish --tag=laravel-mail (At this point, password reset emails should look fine)
  3. Upgrade to 5.7 (At this point, password reset emails look clumsy at best).
  4. (Bonus): Copy the stylesheet from the vendor directory into the previously published mail themes directory, and all appears to work again.

Before & After Upgrade Screenshots

Screenshot from 5.6:

2018-09-12 at 3 54 pm

Screenshot from 5.7:

2018-09-12 at 3 53 pm

@staudenmeir
Copy link
Contributor

Can you submit a PR to https://github.com/laravel/docs?

@staudenmeir
Copy link
Contributor

Can you close the issue?

@CodeCooler
Copy link
Author

Looks like @dwightwatson beat me to it. Thanks, and closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants