Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Flakey memcached tests #29777

Closed
GrahamCampbell opened this issue Aug 28, 2019 · 6 comments · Fixed by #31646
Closed

[6.x] Flakey memcached tests #29777

GrahamCampbell opened this issue Aug 28, 2019 · 6 comments · Fixed by #31646
Labels

Comments

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Aug 28, 2019

  • Laravel Version: 5.8+
  • PHP Version: 7
  • Database Driver & Version: N/A

Description:

I see this every few days within the travis builds:

There were 2 failures:

1) Illuminate\Tests\Integration\Cache\MemcachedTaggedCacheTest::test_memcached_can_store_and_retrieve_tagged_cache_items

Failed asserting that null matches expected 'foo'.

/home/travis/build/laravel/framework/tests/Integration/Cache/MemcachedTaggedCacheTest.php:19

2) Illuminate\Tests\Integration\Cache\MemcachedTaggedCacheTest::test_memcached_can_store_many_tagged_cache_items

Failed asserting that null matches expected 'foo'.

/home/travis/build/laravel/framework/tests/Integration/Cache/MemcachedTaggedCacheTest.php:41

@driesvints driesvints added the bug label Aug 29, 2019
@driesvints
Copy link
Member

Yeah we need to get that fixed. I've seen that sporadically happen as well.

@driesvints
Copy link
Member

Going on a limb here and assume this is fixed in Github Actions. If we see it pop back up we can reopen.

@GrahamCampbell GrahamCampbell changed the title [5.8] Flakey memcached tests [6.x] Flakey memcached tests Feb 24, 2020
@GrahamCampbell
Copy link
Member Author

This is still happening, even on GitHub actions. The last build of master just failed:

image

@ryangjchandler
Copy link
Contributor

Is it possible that the TTL of 1 second isn't actually enough sometimes and when the assertion is run, the cache has actually expired?

@driesvints
Copy link
Member

@ryangjchandler that can indeed be it. Sending in a pr.

@ryangjchandler
Copy link
Contributor

ryangjchandler commented Feb 28, 2020

@ryangjchandler that can indeed be it. Sending in a pr.

🤞🏼. If not, then I'll have to take another look but that's the only reason I can see null being returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants