Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Consider mailto and tel links in the Notification subcopy $actionUrl label #31522

Closed
hofmannsven opened this issue Feb 18, 2020 · 0 comments

Comments

@hofmannsven
Copy link
Contributor

Description:

The default Notification email template does not take care of mailto: and tel: links in the subcopy slot. The $actionUrl label is not readable and it is not possible to copy and paste the link from the email.

Steps to reproduce:

  1. Create a new Notification:
php artisan make:notification InvoicePaid
  1. Add an email address (or phone number) as action URL in App\Notifications\InvoicePaid:
public function toMail($notifiable)
{
    return (new MailMessage)
                ->line('The introduction to the notification.')
                ->action('Notification Action', 'mailto:test@example.com')
                ->line('Thank you for using our application!');
}
  1. Trigger the Notification:
$user->notify(new App\Notifications\InvoicePaid());

The (default) text in the subcopy of the email now reads as:

If you’re having trouble clicking the "Notification Action" button, copy and paste the URL below
into your web browser: mailto:test@example.com

Request:

Consider stripping mailto: and tel: from the subcopy $actionUrl label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant