Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpdoc errors found with Doctum #35673

Closed
williamdes opened this issue Dec 19, 2020 · 3 comments
Closed

phpdoc errors found with Doctum #35673

williamdes opened this issue Dec 19, 2020 · 3 comments

Comments

@williamdes
Copy link
Contributor

williamdes commented Dec 19, 2020

  • Laravel Version: 5,6,7,8

Description:

I am working on Doctum 5.3.0-dev and testing it against your codebase.

Current errors

 Updating project 

Version 5.5
  Parsing   done
ERROR: The "r" @param tag variable name is wrong (should be "notification") on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:142
ERROR: The "route" @param tag variable name is wrong (should be "request") on "Illuminate\Routing\Router::runRoute" in build/doctum/laravel/src/Illuminate/Routing/Router.php:626
ERROR: The "request" @param tag variable name is wrong (should be "route") on "Illuminate\Routing\Router::runRoute" in build/doctum/laravel/src/Illuminate/Routing/Router.php:626
ERROR: The "constraints;" @param tag variable name is wrong (should be "constraints") on "Illuminate\Validation\Rules\Dimensions::__construct" in build/doctum/laravel/src/Illuminate/Validation/Rules/Dimensions.php:20
ERROR: "3" @param tags are expected but only "2" found on "Illuminate\Foundation\Http\Middleware\TransformsRequest::handle" in build/doctum/laravel/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php:24
ERROR: The "key" @param tag variable name is wrong (should be "keys") on "Illuminate\Http\Concerns\InteractsWithInput::hasAny" in build/doctum/laravel/src/Illuminate/Http/Concerns/InteractsWithInput.php:100
ERROR: "2" @param tags are expected but only "3" found on "Illuminate\Database\Query\Grammars\PostgresGrammar::compileDeleteWithJoins" in build/doctum/laravel/src/Illuminate/Database/Query/Grammars/PostgresGrammar.php:266

  Rendering done

Version 5.8
  Parsing   done
ERROR: The "r" @param tag variable name is wrong (should be "notification") on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:173
ERROR: The "constraints;" @param tag variable name is wrong (should be "constraints") on "Illuminate\Validation\Rules\Dimensions::__construct" in build/doctum/laravel/src/Illuminate/Validation/Rules/Dimensions.php:20
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Mail\PendingMail::sendNow" in build/doctum/laravel/src/Illuminate/Mail/PendingMail.php:136
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Mail\PendingMail::queue" in build/doctum/laravel/src/Illuminate/Mail/PendingMail.php:147
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Mail\PendingMail::later" in build/doctum/laravel/src/Illuminate/Mail/PendingMail.php:165
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Mail\PendingMail::fill" in build/doctum/laravel/src/Illuminate/Mail/PendingMail.php:176
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::send" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:27
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::sendNow" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:38
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::queue" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:49

  Rendering done

Version 6.x
  Parsing   done
ERROR: The "r" @param tag variable name is wrong (should be "notification") on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The "constraints;" @param tag variable name is wrong (should be "constraints") on "Illuminate\Validation\Rules\Dimensions::__construct" in build/doctum/laravel/src/Illuminate/Validation/Rules/Dimensions.php:20
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::send" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:27
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::sendNow" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:38
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::queue" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:49

  Rendering done

Version 7.x
  Parsing   done
ERROR: The "r" @param tag variable name is wrong (should be "notification") on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The "constraints;" @param tag variable name is wrong (should be "constraints") on "Illuminate\Validation\Rules\Dimensions::__construct" in build/doctum/laravel/src/Illuminate/Validation/Rules/Dimensions.php:20
ERROR: "2" @param tags are expected but only "1" found on "Illuminate\Foundation\Bus\Dispatchable::dispatchIf" in build/doctum/laravel/src/Illuminate/Foundation/Bus/Dispatchable.php:26
ERROR: "2" @param tags are expected but only "1" found on "Illuminate\Foundation\Bus\Dispatchable::dispatchUnless" in build/doctum/laravel/src/Illuminate/Foundation/Bus/Dispatchable.php:39
ERROR: "2" @param tags are expected but only "1" found on "Illuminate\Foundation\Events\Dispatchable::dispatchIf" in build/doctum/laravel/src/Illuminate/Foundation/Events/Dispatchable.php:23
ERROR: "2" @param tags are expected but only "1" found on "Illuminate\Foundation\Events\Dispatchable::dispatchUnless" in build/doctum/laravel/src/Illuminate/Foundation/Events/Dispatchable.php:36
ERROR: "2" @param tags are expected but only "3" found on "Illuminate\Database\Query\Grammars\MySqlGrammar::whereNull" in build/doctum/laravel/src/Illuminate/Database/Query/Grammars/MySqlGrammar.php:25
ERROR: The "columns" @param tag variable name is wrong (should be "query") on "Illuminate\Database\Query\Grammars\MySqlGrammar::whereNotNull" in build/doctum/laravel/src/Illuminate/Database/Query/Grammars/MySqlGrammar.php:43
ERROR: The "boolean" @param tag variable name is wrong (should be "where") on "Illuminate\Database\Query\Grammars\MySqlGrammar::whereNotNull" in build/doctum/laravel/src/Illuminate/Database/Query/Grammars/MySqlGrammar.php:43
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::send" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:27
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::sendNow" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:39
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::queue" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:50

  Rendering done

Version 8.x
  Parsing   done
ERROR: The "r" @param tag variable name is wrong (should be "notification") on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The "constraints;" @param tag variable name is wrong (should be "constraints") on "Illuminate\Validation\Rules\Dimensions::__construct" in build/doctum/laravel/src/Illuminate/Validation/Rules/Dimensions.php:20
ERROR: "0" @param tags are expected but only "1" found on "Illuminate\Http\Client\Response::throw" in build/doctum/laravel/src/Illuminate/Http/Client/Response.php:236
ERROR: "4" @param tags are expected but only "3" found on "Illuminate\Cache\CacheLock::__construct" in build/doctum/laravel/src/Illuminate/Cache/CacheLock.php:23
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::send" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:27
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::queue" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:38

  Rendering done

Version master
  Parsing   done
ERROR: The "r" @param tag variable name is wrong (should be "notification") on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The "constraints;" @param tag variable name is wrong (should be "constraints") on "Illuminate\Validation\Rules\Dimensions::__construct" in build/doctum/laravel/src/Illuminate/Validation/Rules/Dimensions.php:20
ERROR: "0" @param tags are expected but only "1" found on "Illuminate\Http\Client\Response::throw" in build/doctum/laravel/src/Illuminate/Http/Client/Response.php:236
ERROR: The "schema" @param tag variable name is wrong (should be "searchPath") on "Illuminate\Database\Schema\Grammars\PostgresGrammar::compileGetAllViews" in build/doctum/laravel/src/Illuminate/Database/Schema/Grammars/PostgresGrammar.php:263
ERROR: "4" @param tags are expected but only "3" found on "Illuminate\Cache\CacheLock::__construct" in build/doctum/laravel/src/Illuminate/Cache/CacheLock.php:23
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::send" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:27
ERROR: The "mailable;" @param tag variable name is wrong (should be "mailable") on "Illuminate\Support\Testing\Fakes\PendingMailFake::queue" in build/doctum/laravel/src/Illuminate/Support/Testing/Fakes/PendingMailFake.php:38

  Rendering done

 Version    Updated C    Removed C 
      5.5          770            0
      5.8          829            0
      6.x          850            0
      7.x          871            0
      8.x          951            0
   master          952            0

 Version    Updated C    Updated N    Removed C    Removed N 
      5.5          770          151            0            0
      5.8          829          152            0            0
      6.x          848          153            0            0
      7.x          870          156            0            0
      8.x          950          163            0            0
   master          951          163            0            0


Errors on 5.3.0-dev

 Updating project 

Version 5.5
------------
  Parsing   done

ERROR: The method "compileDeleteWithJoins" has "3" @param tags but only "2" where expected. on "Illuminate\Database\Query\Grammars\PostgresGrammar::compileDeleteWithJoins" in build/doctum/laravel/src/Illuminate/Database/Query/Grammars/PostgresGrammar.php:266
ERROR: The "attributes" parameter of the method "handle" is missing a @param tag on "Illuminate\Foundation\Http\Middleware\TransformsRequest::handle" in build/doctum/laravel/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php:24
ERROR: The method "cache" has "1" @param tags but only "0" where expected. on "\cache" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:224
ERROR: The "args" parameter of the method "event" is missing a @param tag on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:465
ERROR: The method "event" has "3" @param tags but only "1" where expected. on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:465
ERROR: The method "factory" has "1" @param tags but only "0" where expected. on "\factory" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:478
ERROR: The "keys" parameter of the method "hasAny" is missing a @param tag on "Illuminate\Http\Concerns\InteractsWithInput::hasAny" in build/doctum/laravel/src/Illuminate/Http/Concerns/InteractsWithInput.php:100
ERROR: Invalid @param tag on "queueNotification": "array[\Illuminate\Notifications\Channels\Notification]  $notification" on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:142
ERROR: The "notification" parameter of the method "queueNotification" is missing a @param tag on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:142
ERROR: The method "queueNotification" has "1" invalid @param tags. on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:142

 804/804 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 9 secs
  Rendering                                           Rendering done

 931/931 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 16 secs


Version 5.8
------------
  Parsing   done

ERROR: The hint on "startedAt" at @var is invalid: "\Illuminate\Support\Carbon;" on "Illuminate\Console\Scheduling\ScheduleRunCommand::$startedAt" in build/doctum/laravel/src/Illuminate/Console/Scheduling/ScheduleRunCommand.php:36
ERROR: The method "cache" has "1" @param tags but only "0" where expected. on "\cache" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:235
ERROR: The "args" parameter of the method "event" is missing a @param tag on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:480
ERROR: The method "event" has "3" @param tags but only "1" where expected. on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:480
ERROR: The method "factory" has "1" @param tags but only "0" where expected. on "\factory" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:493
ERROR: Invalid @param tag on "queueNotification": "array[\Illuminate\Notifications\Channels\Notification]  $notification" on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:173
ERROR: The "notification" parameter of the method "queueNotification" is missing a @param tag on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:173
ERROR: The method "queueNotification" has "1" invalid @param tags. on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:173

 867/867 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 12 secs
  Rendering                                           Rendering done

 991/991 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 19 secs


Version 6.x
------------
  Parsing   done

ERROR: The method "cache" has "1" @param tags but only "0" where expected. on "\cache" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:234
ERROR: The "args" parameter of the method "event" is missing a @param tag on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:475
ERROR: The method "event" has "3" @param tags but only "1" where expected. on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:475
ERROR: The method "factory" has "1" @param tags but only "0" where expected. on "\factory" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:488
ERROR: Invalid @param tag on "queueNotification": "array[\Illuminate\Notifications\Channels\Notification]  $notification" on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The "notification" parameter of the method "queueNotification" is missing a @param tag on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The method "queueNotification" has "1" invalid @param tags. on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177

 886/886 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 11 secs
  Rendering                                             Rendering done

 1011/1011 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 20 secs


Version 7.x
------------
  Parsing   done

ERROR: The "where" parameter of the method "whereNull" is missing a @param tag on "Illuminate\Database\Query\Grammars\MySqlGrammar::whereNull" in build/doctum/laravel/src/Illuminate/Database/Query/Grammars/MySqlGrammar.php:25
ERROR: The method "whereNull" has "3" @param tags but only "2" where expected. on "Illuminate\Database\Query\Grammars\MySqlGrammar::whereNull" in build/doctum/laravel/src/Illuminate/Database/Query/Grammars/MySqlGrammar.php:25
ERROR: The "where" parameter of the method "whereNotNull" is missing a @param tag on "Illuminate\Database\Query\Grammars\MySqlGrammar::whereNotNull" in build/doctum/laravel/src/Illuminate/Database/Query/Grammars/MySqlGrammar.php:43
ERROR: The "arguments" parameter of the method "dispatchIf" is missing a @param tag on "Illuminate\Foundation\Bus\Dispatchable::dispatchIf" in build/doctum/laravel/src/Illuminate/Foundation/Bus/Dispatchable.php:26
ERROR: The "arguments" parameter of the method "dispatchUnless" is missing a @param tag on "Illuminate\Foundation\Bus\Dispatchable::dispatchUnless" in build/doctum/laravel/src/Illuminate/Foundation/Bus/Dispatchable.php:39
ERROR: The "arguments" parameter of the method "dispatchIf" is missing a @param tag on "Illuminate\Foundation\Events\Dispatchable::dispatchIf" in build/doctum/laravel/src/Illuminate/Foundation/Events/Dispatchable.php:23
ERROR: The "arguments" parameter of the method "dispatchUnless" is missing a @param tag on "Illuminate\Foundation\Events\Dispatchable::dispatchUnless" in build/doctum/laravel/src/Illuminate/Foundation/Events/Dispatchable.php:36
ERROR: The method "cache" has "1" @param tags but only "0" where expected. on "\cache" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:233
ERROR: The "args" parameter of the method "event" is missing a @param tag on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:474
ERROR: The method "event" has "3" @param tags but only "1" where expected. on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:474
ERROR: Invalid @param tag on "queueNotification": "array[\Illuminate\Notifications\Channels\Notification]  $notification" on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The "notification" parameter of the method "queueNotification" is missing a @param tag on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The method "queueNotification" has "1" invalid @param tags. on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177

 906/906 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 13 secs
  Rendering                                             Rendering done

 1036/1036 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 21 secs


Version 8.x
------------
  Parsing   done

ERROR: The "store" parameter of the method "__construct" is missing a @param tag on "Illuminate\Cache\CacheLock::__construct" in build/doctum/laravel/src/Illuminate/Cache/CacheLock.php:23
ERROR: The method "cache" has "1" @param tags but only "0" where expected. on "\cache" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:233
ERROR: The "args" parameter of the method "event" is missing a @param tag on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:430
ERROR: The method "event" has "3" @param tags but only "1" where expected. on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:430
ERROR: The method "throw" has "1" @param tags but only "0" where expected. on "Illuminate\Http\Client\Response::throw" in build/doctum/laravel/src/Illuminate/Http/Client/Response.php:236
ERROR: Invalid @param tag on "queueNotification": "array[\Illuminate\Notifications\Channels\Notification]  $notification" on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The "notification" parameter of the method "queueNotification" is missing a @param tag on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The method "queueNotification" has "1" invalid @param tags. on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177

 988/988 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 15 secs
  Rendering                                             Rendering done

 1123/1123 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 23 secs


Version master
---------------
  Parsing   done

ERROR: The "store" parameter of the method "__construct" is missing a @param tag on "Illuminate\Cache\CacheLock::__construct" in build/doctum/laravel/src/Illuminate/Cache/CacheLock.php:23
ERROR: The "searchPath" parameter of the method "compileGetAllViews" is missing a @param tag on "Illuminate\Database\Schema\Grammars\PostgresGrammar::compileGetAllViews" in build/doctum/laravel/src/Illuminate/Database/Schema/Grammars/PostgresGrammar.php:263
ERROR: The method "cache" has "1" @param tags but only "0" where expected. on "\cache" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:233
ERROR: The "args" parameter of the method "event" is missing a @param tag on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:430
ERROR: The method "event" has "3" @param tags but only "1" where expected. on "\event" in build/doctum/laravel/src/Illuminate/Foundation/helpers.php:430
ERROR: The method "throw" has "1" @param tags but only "0" where expected. on "Illuminate\Http\Client\Response::throw" in build/doctum/laravel/src/Illuminate/Http/Client/Response.php:236
ERROR: Invalid @param tag on "queueNotification": "array[\Illuminate\Notifications\Channels\Notification]  $notification" on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The "notification" parameter of the method "queueNotification" is missing a @param tag on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177
ERROR: The method "queueNotification" has "1" invalid @param tags. on "Illuminate\Notifications\NotificationSender::queueNotification" in build/doctum/laravel/src/Illuminate/Notifications/NotificationSender.php:177

 989/989 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 13 secs
  Rendering                                             Rendering done

 1124/1124 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 23 secs


 Version    Updated C    Removed C 
      5.5          770            0
      5.8          829            0
      6.x          850            0
      7.x          871            0
      8.x          951            0
   master          952            0

 Version    Updated C    Updated N    Removed C    Removed N 
      5.5          770          151            0            0
      5.8          829          152            0            0
      6.x          848          153            0            0
      7.x          870          156            0            0
      8.x          950          163            0            0
   master          951          163            0            0


I am planning to upgrade the https://github.com/laravel/laravel.com-next repository after the release.

What should I do for the different phpdoc errors reported ?
I agree to fix them on each branch or let you do it, there is not much errors

ℹ️
Doctum now has:

  • A GitHub action
  • Different output formats for errors including the GitHub format
  • Non class files support (functions files) but using a namespace
  • An option to have a link below the footer link to write some text and a link for your api docs users (5.3.0-dev)
@taylorotwell
Copy link
Member

No idea really. If you want to fix them that is fine. I don't plan to fix them atm myself. If others want to submit a PR that is fine too.

@williamdes
Copy link
Contributor Author

No idea really. If you want to fix them that is fine. I don't plan to fix them atm myself. If others want to submit a PR that is fine too.

Okay, I will probably make PRs
Let me know is some branches are frozen so I do not waste fixing time :)

@driesvints
Copy link
Member

@williamdes tbvh we regularly get DocBlock prs for tools like phpstan, etc and in general we don't optimize for these. You're free to send in prs (definitely appreciate you helping out here) but we can't make any promises of those being merged.

Best to only send to the current active branch (8.x).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants