Calling forceCreate() on a MorphMany relation doesn't includes morph type

[DarkGhostHunter]

• Laravel Version: 9.17
• PHP Version: 8.0.23
• Database Driver & Version: N/A

Description:

When using forceCreate() on a morph relation (morphOne|morphMany), the morph type column is not added.

$post->comments()->forceCreate(['body' => 'Cool article']);

This behavior is realated to #42281.

Steps To Reproduce:

class Post extends Model
{
    public $fillable = ['*'];
    public function comments() { return $this->morphMany(Comment::class, 'commentable'); }
}

class Comment extends Model
{
    public function commentable() { return $this->morphTo(); }
}

$post = Post::create(['body' => 'Hello world!']);

$post->comments()->forceCreate(['body' => 'Cool article']);

// Illuminate\Database\QueryException : 
//   SQLSTATE[23000]: 
//     Integrity constraint violation: 
//       19 NOT NULL constraint failed: comments.commentable_type
//       ...

[AbdlrahmanSaberAbdo]

As I understand make doesn't create a new row in the database it just creates a new instance of the class you request, I tried to test your code with create instead of make, and it's worked well, because create persists to the database, the code will be like this

$post = Post::create(['body' => 'Hello world!']);

$post->comments()->forceCreate(['body' => 'Cool article']);

I'm not sure if it should also work well with make or not because make will not return a new id, so even if he knows the commentable_type, he'll give another error because it didn't know the commentable_id in your case, correct me if I'm wrong?

[DarkGhostHunter]

As I understand make doesn't create a new row in the database it just creates a new instance of the class you request, I tried to test your code with create instead of make, and it's worked well, because create persists to the database, the code will be like this

$post = Post::create(['body' => 'Hello world!']);

$post->comments()->forceCreate(['body' => 'Cool article']);

I'm not sure if it should also work well with make or not because make will not return a new id, so even if he knows the commentable_type, he'll give another error because it didn't know the commentable_id in your case, correct me if I'm wrong?

You're correct, my example was bad. I used create, so I fixed the example.

[BrandonSurowiec]

Looks like a fix was accepted: #42929