Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whoops! Stack trace styling gone wonky. #4715

Closed
tonydew opened this issue Jun 15, 2014 · 6 comments
Closed

Whoops! Stack trace styling gone wonky. #4715

tonydew opened this issue Jun 15, 2014 · 6 comments

Comments

@tonydew
Copy link

tonydew commented Jun 15, 2014

After a composer update earlier today, the Whoops! stack trace changed appearance:

laravel_4_2_3_whoops_now_blue

While troubleshooting, I ran artisan cache:clear and artisan clear-compiled but had no luck. Still blue. Then I set composer.json to require "laravel/framework": "4.2.0" and did another composer update and then artisan cache:clear and artisan clear-compiled

All good! Got the cool orange styling back. So then, I stepped through each iteration. 4.2.1 is fine. Then 4.2.2 looks like this:

laravel_4_2_2_whoops_dying

Then 4.2.3 goes back to looking like the slightly unfinished blue colored one.

Looks like there has been some work to clean Remove some unnecessary Whoops files. recently. Maybe were a little more necessary than first thought?

I know it's just styling, but I thought you'd like to know.

@barryvdh
Copy link
Contributor

This is on purpose. This is the original whoops styling, and custom Laravel styling has been removed for maintainability.

@tonydew
Copy link
Author

tonydew commented Jun 15, 2014

Oh, well that is understandable, if not a bit disappointing. The custom Laravel styling was a really polished element, albeit seen by very few people I guess.

Was there an announcement or some in the change logs that I missed?

@barryvdh
Copy link
Contributor

See the discussion here: #4378 (comment)
No announcement, it isn't really breaking I guess, just a different style.
But besides the color, Whoops is probably open of styling improvements in the core, if you want.

@tonydew
Copy link
Author

tonydew commented Jun 15, 2014

Yes, I'd seen that discussion as of a few minutes ago. Thank you for following up.

@tonydew tonydew closed this as completed Jun 15, 2014
@vladshcherbin
Copy link

@tonydew
hello, I`ve had the same problem and updated whoops css file with the colors / fonts from the previous version

If you want the orange color and old font size, here is my repo with css, I`ll update it on whoops updates.
Current css file version is for whoops 1.1.1
https://github.com/VladShcherbin/whoops-orange-laravel-colors
copy the file to

vendor/filp/whoops/src/Whoops/Resources/css/

Default

alt text

Old (orange)

alt text

@tonydew
Copy link
Author

tonydew commented Jun 17, 2014

Hey! Cool. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants