You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds a StyleInterface with a few common helpers, similar to the helpers that Laravel currently adds.
Perhaps it would be a good idea to make a Laravel Style, that perhaps extends the Symfony one. The existing helper functions could be redirected to the Style ouput, new methods can also be directed to the style helper or be available as $style for example.
The OutputStyle also implements the OutputInterface, so the Output could be changed to the OutputStyle.
Pros:
Easier to use
Prettier ouput
Uniformity between commands
Leverage Symfony helpers/code
Interoperability with Symfony
Cons:
Some helpers have different signatures, so might give confusion.
As this is for 5.1 (because only in Symfony 2.7), we could change the signatures perhaps, if it's worth the BC break. Otherwise keep the existing method signatures and make the style available for new helpers.
I could make a PR for this if wanted.
The text was updated successfully, but these errors were encountered:
In Symfony 2.7, Style Guide helpers are added (see symfony/symfony#14057 and symfony/symfony@96b4210 )
This adds a StyleInterface with a few common helpers, similar to the helpers that Laravel currently adds.
Perhaps it would be a good idea to make a Laravel Style, that perhaps extends the Symfony one. The existing helper functions could be redirected to the Style ouput, new methods can also be directed to the style helper or be available as $style for example.
The OutputStyle also implements the OutputInterface, so the Output could be changed to the OutputStyle.
Pros:
Cons:
Example:
Table with current/symfony helpers:
As this is for 5.1 (because only in Symfony 2.7), we could change the signatures perhaps, if it's worth the BC break. Otherwise keep the existing method signatures and make the style available for new helpers.
I could make a PR for this if wanted.
The text was updated successfully, but these errors were encountered: