Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing app name can leave app / artisan in a non-working state #16575

Closed
jimbojsb opened this issue Nov 28, 2016 · 1 comment
Closed

Changing app name can leave app / artisan in a non-working state #16575

jimbojsb opened this issue Nov 28, 2016 · 1 comment

Comments

@jimbojsb
Copy link

  • Laravel Version: 5.3.x
  • PHP Version: 7.0.x

Description:

If you delete the database/ folder from a Laravel app created by using composer create-project laravel/laravel (for any reason, but lets assume it's because your app has no DB), later using artisan app:name MyApp can't update the database factory namespaces. This causes the command to fail, which means the composer calls to regenerate autoloaders never get run, thus leaving your app in a non-working state. Manually running composer can be used to fix this issue, but it seems reasonable that this should fail more gracefully.
@themsaid
Copy link
Member

What do you suggest?

ralphschindler added a commit to ralphschindler/laravel-framework that referenced this issue Nov 29, 2016
@ralphschindler
Fixes issue laravel#16575
7a7bc0b 
- add file exists check to ModelFactory.php file when performing app:name command
@ralphschindler ralphschindler mentioned this issue Nov 29, 2016
Merged
@themsaid themsaid closed this as completed Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimbojsb @themsaid