New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move state management to Vuex #53
Comments
I think it's fine as it is for now :) Sorry but at this stage trying to keep the focus on enhancing the backend and make sure it works efficiently, maybe later we can look at making such changes. |
@themsaid Happy to tackle this, while you guys work on API/backend. It was more of a TODO down the track. |
I suggest that Laravel would benefit from general integrated support for VueX and the framework should start there, rather than a specialized solution for Horizon. Otherwise, the solution for this could collide with custom Vue / VueX implementations for each application. |
I really believe we shouldn't go this way, @milosdakic please don't spend time on this at this early stage of Horizon :) I don't think Taylor would be interested in reviewing such change at the moment, and myself the same. Would just say we look into Horizon backend at the moment and make sure it's solid enough and production ready. |
Out of curiosity, did this project start as an SPA? I ask because I imagine if you knew that, then Vuex may have been implemented from the beginning. Just curious, thanks. |
I agree with @themsaid since this is still in Beta |
Unless we have concrete improvements it will bring no point IMO. |
I agree with @SirLamer, I would love for Laravel's vue.js bootstrapping to come with Vuex baked in going forward. Not just related to Horizon but Laravel in general. |
@themsaid @taylorotwell had POC ready in 20min 😢 See you point in regards to Horizon not being at a stage where this work might be of benefit. However, seeing as its OSS and for the time being only focused on Redis, once community starts adding other queue services this will quickly grow. Therefore this being a need sooner rather than later 😃 Either way up to you guys, I'm happy to contribute back where needed. PS. Branch sitting here: |
State is currently managed per component/page. Moving to Vuex will allow better state management and enable data sharing between components/pages.
Items to be worked on
The text was updated successfully, but these errors were encountered: